search

gdg-x / hub

[DEPRECATED] API Data Hub for the Global GDG Community
https://hub.gdgx.io
Apache License 2.0
36 stars 19 forks source link

Fix Redis #78

Closed Splaktar closed 8 years ago

Splaktar commented 8 years ago

The JSONP issue that was affecting Firefly is fixed. Issues where the stats or other API responses might be different within a few minutes is fixed.

Managed to upgrade Express, redis-node, connect-redis, and a few other packages without breaking anything.

Problems seemed to be caused by our redis node 1 not being reachable via the internal network. Moving to node 3 is working for now. More attention needs to be put into making Redis and other parts of the system more HA, but that's really a full time job sort of thing...

See commit logs for more details.

This is currently deployed to production since some of these changes were required to get the Hub back online.

Fixes #79.

tasomaniac commented 8 years ago

Although code style fixes are really important, they make code review harder. I wanted to review but I was lost. :(

tasomaniac commented 8 years ago

I know your job here is hard and this bug has to be fixed asap. I think you can merge it.

Splaktar commented 8 years ago

Yeah, sorry. Realistically, I don't think any of the code changes actually fixed the primary issue which turned out to be Chinese hackers.

So these changes are mostly just clean up and upgrading of 1+ year old / deprecated packages.

Splaktar commented 8 years ago

@tasomaniac Oh and the real fixes were all in the GCP Console (firewall rules and deployment of a new Redis VM). I gave you an invite with access to view the GCP project yesterday.

tasomaniac commented 8 years ago

Yes, I received the invite. Thank you :)

tasomaniac commented 8 years ago

:100: