Wrong displaying of team/speaker images.

gdg-x / zeppelin

Awesome conference website in 5 minutes.

http://gdg-x.github.io/zeppelin/

MIT License

678 stars 934 forks source link

Closed AlexKorovyansky closed 10 years ago

AlexKorovyansky commented 10 years ago

Usage of rectangle images for team members or speakers cause bug of its displaying — https://cloudup.com/clzcxITuvAq (images are vertically repeating). I was able to make simple workaround — https://github.com/GDGOmsk/devfest-site/commit/795785a82203391d4ef88f9cc7be27238c2fde41, but I'm sure you can come up with better solution.

ozasadnyy commented 10 years ago

Thanks @korovyansk I will fix it.

joshuawoodward commented 10 years ago

https://github.com/gdg-x/zeppelin/pull/6 should fix the issue. Looks like background-size: cover; is being overridden to % values.

tested briefly, and not sure if it affects other behavior, double check before merging :)

ozasadnyy commented 10 years ago

@joshuawoodward it will fix background repeating but disable hover effect... I will try to find another way to do this

joshuawoodward commented 10 years ago

my fix looks pretty nice :) and the hover is awesome with the name/icons

ozasadnyy commented 10 years ago

@joshuawoodward I have merged your PR) Next I will add it to my Sass files (I'm working on migrating to it)