search

gdg-x / zeppelin

Awesome conference website in 5 minutes.
http://gdg-x.github.io/zeppelin/
MIT License
678 stars 933 forks source link

Script minification bash scripts are added. #54

Closed tasomaniac closed 9 years ago

ozasadnyy commented 9 years ago

Thanks for contribution!

tasomaniac commented 9 years ago

Thank you for the great project. :)

master and develop branches are kinda odd right now. develop and gh-pages are behind master.

ozasadnyy commented 9 years ago

I will update all branches with next release.

zasadnyy commented 9 years ago

@tasomaniac thanks for contribution. Could you please also update wiki page ?

tasomaniac commented 9 years ago

Hey, I've updated the wiki page. And I deleted the page about App Engine. I think it is from past and unrelated. You can revert it if you want. Sorry if it was a mistake :)

So, the wiki page was confusing. There is no minify_all.bat and minify_css.bat, and corresponding .sh files. What happened to those? If you put those, I can create the corresponding .sh files for them. If we deleted those, we should update README and wiki pages.

zasadnyy commented 9 years ago

@ozasadnyy could you please check?

ozasadnyy commented 9 years ago

Yep, it's my mistake. I have deleted that bash files but forgot to edit wiki page.

tasomaniac commented 9 years ago

But why we don't have scripts for css files?

I am developing our wtm15 web page. And one of my friends make a change in the main css file. Since it is already one line file I cannot see the difference.

Should we do the css just like scripts and have minified version separately

On Sun, Feb 22, 2015, 8:52 PM Oleh Zasadnyy notifications@github.com wrote:

Yep, it's my mistake. I have deleted that bash files but forgot to edit wiki page.

— Reply to this email directly or view it on GitHub https://github.com/gdg-x/zeppelin/pull/54#issuecomment-75450782.

ozasadnyy commented 9 years ago

There is no need for such script. Because when you developing with Sass it will compile for you .min version of styles. Look here: https://github.com/gdg-x/zeppelin/wiki/Sass-development#running

tasomaniac commented 9 years ago

Oh I didn't know that. So we should about Wiki and Readme. Also we can add this information about Sass there too. Because they are related.