search

gdgpisa / gdgpisa.github.io

Public website on github-pages for GDG Pisa 🌎🇮🇹💻
http://gdgpisa.it
MIT License
15 stars 8 forks source link

External link should open on a new tab #28

Closed cortinico closed 5 years ago

cortinico commented 6 years ago

We are missing target="_blank" on external links, we should update this to avoid people navigating out from the website.

Expected Behavior

External link should open on a new tab

Actual Behavior

External link open on the same tab

Steps to Reproduce the Problem

  1. E.g. Click on the Meetup link on the homepage

Specifications

grandimk commented 6 years ago

Is this really a bug? Are we sure that we want this behaviour for all external links?

cortinico commented 6 years ago

At least for the one in the navigation drawer and the one in the "projects" page