feat: remove Job interface

gdgvda / cron

a cron library for go

MIT License

13 stars 3 forks source link

feat: remove Job interface #15

Closed janrnc closed 1 year ago

janrnc commented 1 year ago

Removed Job interface and used simple func() instead. Access to external variables or struct properties is still possible using closures.
Removed cron.AddFunc(). cron.AddJob() renamed to cron.Add() , taking in this new func() job.
Removed Job and WrappedJob from Entry which made it possible to inspect the scheduled Job struct. Now that jobs are func()s, this is no longer relevant. Job struct management is up to the user who's free to map them to the cron IDs in the preferred way.

codecov[bot] commented 1 year ago

Codecov Report

Merging #15 (d56396c) into master (6e9e3a0) will decrease coverage by 0.94%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   96.66%   95.73%   -0.94%     
==========================================
  Files           7        7              
  Lines         660      656       -4     
==========================================
- Hits          638      628      -10     
- Misses         18       24       +6     
  Partials        4        4

Files	Coverage Δ
chain.go	`93.02% <100.00%> (ø)`
cron.go	`92.39% <100.00%> (-3.36%)`	:arrow_down:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: