Feature request: disabling PDF Viewer on specific sites

gdh1995 / vimium-c-helpers

Some helper extensions to extend Vimium C's functionality

MIT License

44 stars 7 forks source link

Feature request: disabling PDF Viewer on specific sites #10

Open infokiller opened 3 years ago

infokiller commented 3 years ago

It seems that some sites dynamically load a PDF which stops working when using the PDF Viewer for Vimium C. Chromium doesn't support disabling an extension in specific sites (only enabling them in specific sites), so this requires me to disable the extension, load the problematic website, then re-enable the extension.

Thanks!

gdh1995 commented 3 years ago

PDF Viewer for Vimium C has a special option named Prefer keeping URLs in the address bar unchanged, and please try disabling it and recheck whether your sites work or not.

infokiller commented 3 years ago

Thanks, but it didn't help, see the error I'm getting below. Looking at the html, the issue may be that it tries to directly use the chrome pdf viewer?

Here's the html element copied from Chromium's inspect element:

<embed id="plugin" type="application/x-google-chrome-pdf" src="https://hb2.bankleumi.co.il/eBanking/SupportAndReports/ShowMailPDF.aspx?isResize=no" stream-url="chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/4036ae14-f899-451b-952b-7d5ab46a16ce" headers="Access-Control-Allow-Headers: Content-Type
Access-Control-Allow-Methods: GET, POST
Cache-Control: private
Content-Disposition: inline;filename=MailPDF2021_04_27_03_34_10.pdf
Content-Length: 178122
Content-Type: application/pdf
Date: Tue, 27 Apr 2021 12:34:10 GMT
Strict-Transport-Security: max-age=16070400; includeSubDomains
Vary: Accept-Encoding
X-DNS-Prefetch-Control: off
X-FRAME-OPTIONS: SAMEORIGIN
" background-color="4283586137" javascript="allow" top-level-url="undefined" pdf-viewer-update-enabled="">

gdh1995 commented 3 years ago

Um, I'm not sure why this happened. The element belongs to Chrome's native viewer, but not this extension.

Could you disable PDF Viewer for Vimium C, install the official PDF Viewer extension ( https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm) and test again?

If the official extension also breaks your page, then it seems your website uses some tricks to prevent PDF files from being downloaded, which will also prevent extensions from loading it. If so, then there's no way to bypass it.

infokiller commented 3 years ago

Yes, using the official one doesn't work either with this page. Would it be possible to have an option to disable the extension on certain websites, like you can do with vimium-c?

gdh1995 commented 3 years ago

Um, I have no much rest time to modify so many extensions (when maintaining Vimium C). You may need to wait for seasons.

infokiller commented 3 years ago

Thanks, that's fine, I really appreciate all you work, and the extensions are great! When I have some free time, I will try to implement this myself and send a PR