search

gdh1995 / vimium-c

A keyboard shortcut browser extension for keyboard-based navigation and tab operations with an advanced omnibar
https://chrome.google.com/webstore/detail/vimium-c/hfjbmagddngcpeloejdejnfgbamkjaeg
Other
3.33k stars 254 forks source link

Option for setting default color mode in settings (dark / light) #1060

Closed PsyNyde closed 9 months ago

PsyNyde commented 9 months ago

I know there's a button to toggle dark mode but having a default button instead of choosing the browser is providing would be great.

also my reason for making this issue i can't figure out how do I remove the bright border in dark mode:

Preview for dark mode: ![image](https://github.com/gdh1995/vimium-c/assets/75927811/b5c94a8f-f6fd-4866-9372-489eac762ea0)

the border isn't present with light mode. also when the body doesn't have has-dark class:

Preview for light mode: ![image](https://github.com/gdh1995/vimium-c/assets/75927811/504c982c-81e8-44b2-91c7-bd0cccfd8219)
gdh1995 commented 9 months ago
  1. You may partially select the checkbox of Auto switch between light and dark mode:

image

  1. The light border is added by intent, to ensure you may recognize what content belongs to Vomnibar and what doesn't.
    • a. as you see, there's no border shadow in dark mode, so a slim border should be helpful.
PsyNyde commented 9 months ago

aah I'm extremely sorry. Idk how i missed the option. i switched it to light mode initially and it seem to work perfectly fine <3. sorry for the hustle.