Open g-i-o-r-g-i-o opened 5 months ago
No this is not a bug:
Ctrl+W
may close a pinned tabUp to now, if you press Num
+ X
(like 3x
) to close num
tabs, and the current tab is not pinned or near to a pinned, then Vimium C will only close non-pinned tabs.
I admit this feature is not enough, so I'll add a parameter named noPinned
to always prevent removeTab
from removing any pinned tab.
Thanks, that would be very useful
On Monday, January 15, 2024, Dahan Gong @.***> wrote:
No this is not a bug:
- on Chrome, Ctrl+W may close a pinned tab
- there should be at least one way to use Vimium C's shortcut to close a pinned tab
Up to now, if you press Num + X (like 3x) to close num tabs, and the current tab is not pinned or near to a pinned, then Vimium C will only close non-pinned tabs.
I admit this feature is not enough, so I'll add a parameter named noPinned to always prevent removeTab from removing any pinned tab.
— Reply to this email directly, view it on GitHub https://github.com/gdh1995/vimium-c/issues/1073#issuecomment-1892645906, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG2GHFDSGMNQBP5X2EXFFTYOV3JFAVCNFSM6AAAAABBTNNAMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGY2DKOJQGY . You are receiving this because you authored the thread.Message ID: @.***>
@gdh1995 Hi, I need noPinned feature, is there any nightly build with this feature? and do you think the way I write it is correct?
unmap x
map <c-x> removeTab
map x removeTab noPinned=true
拉了最新的源码,按说明编译了一下,安装在Vivaldi浏览器中,noPinned参数似乎无效,无论设置为true还是false,按x键,pinned标签页面始终会被关掉。
Sorry, has this been added to vimium?
Firefox version
thanks
@g-i-o-r-g-i-o Sorry Vimium C v1 is in archive mode and won't be upgraded unless there's any security bug found, while Vimium v2 is still in development - recently, a bit slow - and may be released in the end of 2024.
@lededev Sorry it's because I added an unnecessary limit on the new parameter noPinned
- it required command count >= 2
.
Please try the latest commit (2024-05-20 05:48 009bc06a).
@gdh1995 能用了,谢谢!
Describe the bug
"x", when used on pinned tabs, should not close the tab, since ctrl+w doesn't close the tab
To Reproduce
Steps to reproduce the behavior:
go to a pinned tab press x x closes the tab, while it shouldn't close it: it should probably just do nothing
Browser, OS and Vimium C versions