`performFind` does not move to next match if highlight=true - Githubissues

gdh1995 / vimium-c

A keyboard shortcut browser extension for keyboard-based navigation and tab operations with an advanced omnibar

https://chrome.google.com/webstore/detail/vimium-c/hfjbmagddngcpeloejdejnfgbamkjaeg

Other

3.17k stars 253 forks source link

`performFind` does not move to next match if highlight=true #1112

Open thenbe opened 3 months ago

thenbe commented 3 months ago

Reproduction

Add this to your mappings.
```
map n performFind last highlight
```
Go to https://news.ycombinator.com
Type /
Type com
Hit Enter
Hit n
.
- EXPECTED: move to next match on every time you hit n
- ACTUAL: no movement when you press n

Other

The issue is just with performFind. performBackwardsFind behaves as expected.

# this works fine
map N performBackwardsFind last highlight

This bug is rather old so I don't think it is caused by any recently added code.

Browser, OS and Vimium C versions

Browser name: firefox
Browser version: 123.0.1
Vimium C version: 1.99.997
OS name and version: "x86_64-linux" Linux 6.6.22, NixOS, 24.05 (Uakari)

gdh1995 commented 1 month ago

Confirmed. Seems a bug only happening on Firefox.