gdh1995 / vimium-c

A keyboard shortcut browser extension for keyboard-based navigation and tab operations with an advanced omnibar
https://chrome.google.com/webstore/detail/vimium-c/hfjbmagddngcpeloejdejnfgbamkjaeg
Other
3.29k stars 251 forks source link

Mod+Space pasting link or title in VomniBar #1163

Open HappyCthulhu opened 1 month ago

HappyCthulhu commented 1 month ago

Describe the bug

I already reported about this bug. It was fixed, now it appear again: https://github.com/gdh1995/vimium-c/issues/435

Problem is, shortcut mod+Space changes language on my system. So, i cant change language while im trying to find some link in Vomnibar.

To Reproduce

Steps to reproduce the behavior:

P.S. Mod-button == Windows-key

Browser, OS and Vimium C versions

gdh1995 commented 1 month ago

What's the current test result if you follow https://github.com/gdh1995/vimium-c/issues/435#issuecomment-922367789 ?

HappyCthulhu commented 1 month ago

What's the current test result if you follow #435 (comment) ?

        Event   Code    Key Modifiers   KeyCode (legacy)    Timestamp
1   keydown MetaLeft    Meta        91  7.169
2   keydown Space   GroupNext   Meta    32  7.212
3   keyup   Space   GroupNext   Meta    32  7.282
4   keyup   MetaLeft    Meta    Meta    91  7.417
gdh1995 commented 1 month ago

Oh I see the root case. Thanks for this bug report.

I'll fix it and a new version of v2.x will arrive in days.