gdh1995 / vimium-c

A keyboard shortcut browser extension for keyboard-based navigation and tab operations with an advanced omnibar
https://chrome.google.com/webstore/detail/vimium-c/hfjbmagddngcpeloejdejnfgbamkjaeg
Other
3.39k stars 254 forks source link

Experiencing tabs are auto muted on Vivaldi? #292

Open evanricard opened 3 years ago

evanricard commented 3 years ago

Hey again @gdh1995, I'm using Vivaldi as I mentioned in the last issue of next & previous hinting - this is an unrelated issue to that but..I have noticed that for some reason the communication between the browser, extension, and built-in panels outside of the DOM can fail in unexpected ways.

This is normally fine, but one grievance I have is that when I switch between a "panel" and or any tab that is playing with audio I think that either a variable in your extension or a vivaldi://flag somewhere (possibly) is causing a 'mute' to occur...I'm actually not sure. The only way that I think it may be tied to your extension is that when I press the bind to return to 'unmute' - I found it to be alt-m - then I see a "unmuted" as a notification with your extension and this will fix the issue but I'm not alerted to whatever is muting my tab.

Please let me know if this is topical. Thanks.

gdh1995 commented 3 years ago

Why is this closed? Have you found the real reason?

evanricard commented 3 years ago

I think the problem I did solve lies in having disabled a registry value for a media key...but I am not using that key nor trying to access it in any way in Vim-C. Does Vimium-C even handle audio?

gdh1995 commented 3 years ago

Um, Vimium C will change audio settings only when toggleMuteTab is triggered.

Please test this:

  1. rollback your registry value during tests
  2. open https://gdh1995.cn/vimium-c/keyboard-test.html
  3. turn off Vimium C on it and refresh this page
  4. on this page, press the keys which you once used to switch among tabs, and see what it logs
evanricard commented 3 years ago

There is no problem with my mappings but something is automatically handling what to mute. I'm correctly seeing inputs to navigate to a vivaldi web panel and switch between tabs. Now, I'm just opening a new tab while a youtube video is paused - for example - and the new tab (facebook (or any social media?)) is for some reason muting the youtube tab.

gdh1995 commented 3 years ago
  1. So does it still exist that "an old tab will be muted when you switching to another tab"?
  2. Or did I misunderstand what your first comment said?

opening a new tab while a youtube video is paused

  1. How did you open a new tab? By your browser's native shortcuts like Ctrl+T, or Vimium C's key mappings?
  2. What it will be, if the newly opened tab is a simple text page (like github issue pages), and doesn't include any video areas?
gdh1995 commented 3 years ago

You may open vivaldi://settings/tabs/, go to the bottom and check the status of "Mute Tab Audio".

image

According to https://www.reddit.com/r/vivaldibrowser/comments/95hvll/is_it_possible_to_not_mutepause_youtube/ , Vivaldi itself has a feature to auto mute non-active tabs.

And then I find such a help page: https://vivaldi.com/blog/sound-in-vivaldi/ .

evanricard commented 3 years ago

Thank you for the continued help @gdh1995, yes I have had 'Play All Audio' selected as my preferred way of listening _ from all tabs and panels...I assumed - and I use the native keybinds to open tabs, close tabs, and switch between panels. Ctrl+T, Ctrl+W and Ctrl+Shift+1-2 for web panels. What I can infer is that even though I may use these keybinds that surely have KeyPressDown/Up etc I also use built-in touchpad gestures such as a three-finger swipe down to close a tab or left-right respectively to switch between tabs with Ctrl+PgDn or Up; now, I'm wondering if using the touchpad is causing the keys to "stick" somehow thus causing an unintended audio interaction...but it could be anything really.

an old tab will be muted when you switching to another tab

Yes, ^ but this is not always the case! My audio "failure" does not happen all of the time so that's why this is such a confusing predicament and I've checked vivaldi://flags for other settings of audio. Not a problem if we can't figure it out.

gdh1995 commented 3 years ago

Um, it's hard to guess what's wrong... So are you sure that "if Vimium C is disabled on chrome://extensions, then such an issue will disappear"?

evanricard commented 3 years ago

It seemed that way but I can't say it as 100% sure @gdh1995