gdh1995 / vimium-c

A keyboard shortcut browser extension for keyboard-based navigation and tab operations with an advanced omnibar
https://chrome.google.com/webstore/detail/vimium-c/hfjbmagddngcpeloejdejnfgbamkjaeg
Other
3.29k stars 251 forks source link

Not searchable code #984

Open niksingh710 opened 1 year ago

niksingh710 commented 1 year ago

using firefox image code inside this github block is not searchable if using / to search

gdh1995 commented 1 year ago

Well it's a limitation of Firefox - its webpage APIs don't allow web-extensions to search text in textareas which GitHub uses to "display code"

niksingh710 commented 1 year ago

Well it's a limitation of Firefox - its webpage APIs don't allow web-extensions to search text in textareas which GitHub uses to "display code"

firefox ctrl+f is able to find text in that.

gdh1995 commented 1 year ago

because ctrl-f doesn't use Firefox's webpage API

---Original--- From: "Nikhil @.> Date: Sun, Aug 6, 2023 14:07 PM To: @.>; Cc: "Dahan @.**@.>; Subject: Re: [gdh1995/vimium-c] Not searchable code (Issue #984)

Well it's a limitation of Firefox - its webpage APIs don't allow web-extensions to search text in textareas which GitHub uses to "display code"

firefox ctrl+f is able to find text in that.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

niksingh710 commented 1 year ago

wouldn't it be possible to use that instead of firefox's webpage API?

gdh1995 commented 1 year ago

No. it is conflicted with many features of Vimium C's FindMode, including regexp-finding.

---Original--- From: "Nikhil @.> Date: Mon, Aug 7, 2023 14:29 PM To: @.>; Cc: "Dahan @.**@.>; Subject: Re: [gdh1995/vimium-c] Not searchable code (Issue #984)

wouldn't it be possible to use that instead of firefox's webpage API?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

niksingh710 commented 1 year ago

I guess then it can only be resolved by intervention of Mozilla itself. Issue on Bugzilla.

niksingh710 commented 1 year ago

@gdh1995 Issue

Please check this out once.

gdh1995 commented 1 year ago

I know the API of browser.find.* but it's conflicted with many features of Vimium C's FindMode, including regexp-finding. So Vimium C won't use it.