gdh1995 / vimium-c

A keyboard shortcut browser extension for keyboard-based navigation and tab operations with an advanced omnibar
https://chrome.google.com/webstore/detail/vimium-c/hfjbmagddngcpeloejdejnfgbamkjaeg
Other
3.35k stars 254 forks source link

^ and ° #994

Open recallmenot opened 1 year ago

recallmenot commented 1 year ago

Describe the bug

Hello, I was just learning vimium-c, awesome plugin btw, when using visitPreviousTab I found a bug. I have a german keyboard and I'd like to report that the ^ + ° key (top left) doesn't work as expected.

For reference, ° is shift + ^ and ^ is tapping the key twice to give the option of writing ^, ê ô ĉ etc.
The strange thing is that in "test a key" in options, ^ is correctly identified, while shift+^ produces a ~ instead of °. Typing ~ intentionally in "test a key" (alt + that key on the right side) does also produce a ~. Everywhere else in Firefox (and my OS) the keys are not miss-mapped and work as expected.

When I add map ~ visitPreviousTab and or map <a-w> visitPreviousTab, visitPreviousTab works fine with ALT+W, SHIFT+^ and intentional ~.

To Reproduce

Maybe you can replicate by using German on-screen keyboard? I doubt there are many German keyboards in China ;D

Browser, OS and Vimium C versions

gdh1995 commented 1 year ago

Hello I haven't tested but it should be because of the option named Ignore layout if a key is not located in 7-bit ASCII, and you may turn off it, save options and take a try.

When the option is enabled (by default), the ° key character (char code = 0xB0, 176) will be ignored by Vimium C, while it will try to recognize the key just as you're using an English QWERTY keyboard.

image