search

gdi3d / mute-spotify-ads-mac-osx

Mute Mac (osx) computer audio when Spotify plays an AD
https://gdi3d.github.io/mute-spotify-ads-mac-osx/
MIT License
120 stars 16 forks source link

Guard auto-update from Github #39

Closed pronebird closed 1 year ago

pronebird commented 1 year ago

Amazing script. Thanks for saving me a million hours on stupid ads. Would it be possible to guard auto-update behind some flag?

gdi3d commented 1 year ago

Hi!, thanks for your kind words. Can I ask why would you need/want this? I don't push new versions that often.

pronebird commented 1 year ago

Security measure on my side. I prefer to update manually and inspect all scripts I execute on my computer.

derkommutator commented 1 year ago

If you manually inspect all scripts you execute, you have no doubt already found that it's trivial to disable the auto-update if you wish.

gdi3d commented 1 year ago

@pronebird By default the script won't auto-update itself (default option is No if you hit enter), but I guess I could add a flag for it or a countdown to skip the autoupdate if you don't interact choose an option.

gdi3d commented 1 year ago

@pronebird Hey but the more I think about it, the less sense it makes. The fact that you can choose No when an update it's available solves the issue from my perspective.

If you're worried about bad code being injected, then you should freeze the code yourself by removing the auto-update code from line 6 to 32.

pronebird commented 1 year ago

@gdi3d precisely what I did. I'd appreciate if the script didn't call home but I can certainly remove those lines manually each time I update the script, which is hopefully not often.