Closed Alberdi closed 1 year ago
Hello!, thanks for the contribution. But can you share more info about the printed \r\n. What shell are you using and could you provide a screenshot?
Sure! I'm using the default Terminal (version 2.13) from macOS Ventura 13.4, with a zsh
shell.
This is how I see it:
I did some investigations and found the following. From zsh
:
ᐅ which echo
echo: shell built-in command
ᐅ echo "Test \r\n"
Test
ᐅ echo -e "Test \r\n"
Test
From bash
:
$ which echo
/bin/echo
$ echo "Test \r\n"
Test \r\n
$ echo -e "Test \r\n"
Test
And, since the script invokes /bin/bash
in the first line, I also get the \r\n
displayed when running it. Changing it to /bin/sh
makes it output the empty line in my setup, as it does changing the echo
to echo -e
. But I'm not sure what's a better solution; I could do either as a new commit in this PR if you so desire.
I believe a one-fit-all solution could be just removing the \r\n and adding an empty echo to generate the new lines.
If you can make that change and also update CURRENT_VER
(line 2) to 23
(+1) I'll be glad to accept the PR
There was an extraneous "\r\n" that was always printed in the default terminal, so I removed that one and fixed some other minor typos here and there.