search

gdi3d / mute-spotify-ads-mac-osx

Mute Mac (osx) computer audio when Spotify plays an AD
https://gdi3d.github.io/mute-spotify-ads-mac-osx/
MIT License
120 stars 17 forks source link

enhance and prettify #42

Closed electriquo closed 1 year ago

electriquo commented 1 year ago

@gdi3d anything before a review is requested?

electriquo commented 1 year ago

@gdi3d friendly ping

gdi3d commented 1 year ago

Hey, I'm quite busy these days. I reviewed the code and there are some good changes proposed, but is not solving any really issues. I like to keep the script as simple possible for all audiences so I'm not going to accept the PR, sorry.

electriquo commented 1 year ago

@gdi3d it does improve many things, such as error catching and handling, it is more posix compatible, etc. i am going to keep the fork and i hope it won't draw any focus from yours.

thanks.