search

gdirk07 / PokemonChecker

Playing around with APIs
https://gdirk07.github.io/PokemonChecker/
0 stars 0 forks source link

Pokemon with different types (mega-absol, Deoxys-attack, Giratina-origin etc) have wrong Dex ID #16

Closed gdirk07 closed 2 years ago

gdirk07 commented 2 years ago

image

Based on the API we are using, whenever the pokemon has an altered form that is looked up the ID the API assigns it starts at 10000 and works from there. Looking through the object we should be using the pokemon-species lookup as it generates the national dex (as well as other dex IDs) and lists all their alternative forms

jeremy-jtlo commented 2 years ago

We can probably hide the mega forms from the search results and query all with ID < 10000.

Later on we'll need support for mega forms as part of PokemonDTO