search

gdirk07 / PokemonChecker

Playing around with APIs
https://gdirk07.github.io/PokemonChecker/
0 stars 0 forks source link

Meostic has a larger shiny sprit #27

Closed gdirk07 closed 2 years ago

gdirk07 commented 2 years ago

image

For whatever reason, Meostic's shiny sprite is larger. The solution to this could be to enforce a width/height to sprites, I believe most sprites are 96x96

gdirk07 commented 2 years ago

A forced resize doesn't fully resolve this issue, the problem seems to be the source image. Our Options are

  1. Download the sprite -> fix it -> store it locally to upload
  2. Ask if the owner of the API can fix it
  3. leave it alone

image

gdirk07 commented 2 years ago

Since there's a chance there could be more than one disturbed sprite, it might be worth while to extract all the sprites the API has to offer and compare sizes. Its a lower priority issue since I rather get more features/core components created before hand

jeremy-jtlo commented 2 years ago

We could automate this via python, but yeah I agree it's probably lower priority.

I have a nagging suspicion there is a way to enforce a 'fix' in the view itself by getting creative with CSS, but that will take a lot more reading than I have time for at the moment.

gdirk07 commented 2 years ago

For Now I capped the size to be 96x96 pixels