gdirk07 / PokemonChecker

Playing around with APIs
https://gdirk07.github.io/PokemonChecker/
0 stars 0 forks source link

Returned pokemon names have "-" when its not required and can use some touchup (proper capitalization) #28

Closed gdirk07 closed 2 years ago

gdirk07 commented 2 years ago

It seems that when pokemon have special forms (like shaymin, gourgeist etc), their default name is their default form (shaymin-land, gourgeist-avarage). We should carefully scrub these to only the proper name. Care is needed as some pokemon have "-" in their name naturally like Ho-oh, Mr-Mime etc. Also Nidoran-male and Nidroan-female could use a better name to separate etc To conclude

  1. Scrub alternate form names to just be the name of the pokemon (shaymin-land => shaymin)
  2. Update Nidorans to have updated names (Nidoran-m => Nidoran♂, Nidoran-f => Nidoran♀) this one is more optional, Nidoran-m works and ♂ might have issues rendering on a mutliplatform device.
  3. Capitalizing names (bulbasaur => Bulbasaur).

I think having a hardcoded exception list can help with checking and updating pokemon names. This isn't really blocking any features, but presentation wise would look nice for Milestone #1