gdirk07 / PokemonChecker

Playing around with APIs
https://gdirk07.github.io/PokemonChecker/
0 stars 0 forks source link

Display Ability #59

Closed gdirk07 closed 2 years ago

gdirk07 commented 2 years ago

One of the final keystones for Milestone 1 should be to display the list of abilities with the following properties

  1. list the name of all the abilities the pokemon has (assume latest gen for now)
  2. identify any "Hidden" abilities
  3. on hover, show a description of what the ability does using in-game text
gdirk07 commented 2 years ago

@jeremy-jtlo need your thoughts. Right now on the Pokemon object we populate a list of AbilityDTOs that contain name url and is_hidden, to further get a description we need to fetch the ability from the URL. At what point should this be fetched, in the PokemonFactory upon creation of the pokemon? in the pokemon service when its fetched?