gdirk07 / PokemonChecker

Playing around with APIs
https://gdirk07.github.io/PokemonChecker/
0 stars 0 forks source link

Clean up factory/service calls to their proper structure #79

Closed gdirk07 closed 2 years ago

gdirk07 commented 2 years ago

I think this requires more than a change as DDD implementation can be flexible in its design. From PR #76 a comment was made regarding how it currently works. I feel that hammering what is ok/not okay for factory/service/repository/views to call/handle should be done as a pre-requisite before changing as to maintain consistency that will also help with handling pull requests and code reviews.

This then has 2 items to complete

  1. document what can call a factory, repository, service for consistency.
  2. go through the existing app and make those changes