search

gdirk07 / PokemonChecker

Playing around with APIs
https://gdirk07.github.io/PokemonChecker/
0 stars 0 forks source link

Added initial tests for AbilityFactory and updated AbilityData #85

Closed gdirk07 closed 2 years ago

gdirk07 commented 2 years ago

Wrote initial tests for AbilityFactory to see if it can create stubs and convert them to full ability. Updated AbilityData to contain localized Name

jeremy-jtlo commented 2 years ago

I think this is a good baseline for the factory tests to start with, just need to address the issue that each test should be fully independent of the other tests.

Running unit tests in a randomized order is a pretty common practice, so we should make sure that we're following best practice in that sense. If the suite fails because 2 or more tests didn't go in "the right order," then we have to re-assess our thinking.