gdirk07 / PokemonChecker

Playing around with APIs
https://gdirk07.github.io/PokemonChecker/
0 stars 0 forks source link

Added test and fixed missing ability info #88

Closed gdirk07 closed 2 years ago

gdirk07 commented 2 years ago

Added localizedName test Converted a .then chain function into an async/await function Added a call to the fetchAbilities function in the getPokemon Resolves: #87 I think its reasonable to expect the PokemonServiceto start the process of fetching the associated entities in the PokemonFactory. When it comes to other entities (abilities, moves, and later down the road possibly language, generation etc) what is the proper flow? Should it be the responsibility of PokemonDisplay? For me it makes sense that once a Pokemon is fetched and created, we asynchronously fetch its associated data so it would belong in PokemonService. At this point is where I fail to understand what is proper DDD