search

gdkchan / Ohana3DS-Rebirth

WIP new version of Ohana3DS in C#.
179 stars 40 forks source link

Possible Code Cleanup #10

Closed Fallenleader closed 8 years ago

Fallenleader commented 8 years ago

http://pastebin.com/QS9uRBkh

I have provided a paste-bin of the possible issue commented out with a note, and the possible solution proposed.

Issue: at https://github.com/gdkchan/Ohana3DS-Rebirth/blob/c2371351b03dcf1d15b635b122ad27ef9e612c68/Ohana3DS%20Rebirth/FrmSettings.cs on lines 41 - 64, a function that could possibly be shrunk into a single function is split into two functions. The reasoning behind this is not clear, and the code makes no sense. Is this required due to Visual Studio?

gdkchan commented 8 years ago

Because pressing the Return key (see FrmSettings_KeyDown) also performs the same action of clicking on the OK button.

Fallenleader commented 8 years ago

Noted. Thanks for the clarification.