gdkrmr / WeightedOnlineStats.jl

Weighted version of OnlineStats.jl
MIT License
10 stars 4 forks source link

Add WeightedHist #24

Closed jw3126 closed 5 years ago

jw3126 commented 5 years ago

20

codecov-io commented 5 years ago

Codecov Report

Merging #24 into master will decrease coverage by 1.96%. The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   39.14%   37.17%   -1.97%     
==========================================
  Files           7        7              
  Lines         281      312      +31     
==========================================
+ Hits          110      116       +6     
- Misses        171      196      +25
Impacted Files Coverage Δ
src/histogram.jl 27.35% <12.5%> (-4.05%) :arrow_down:
src/interface.jl 59.09% <0%> (+4.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60e143e...11832b9. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #24 into master will decrease coverage by 1.96%. The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   39.14%   37.17%   -1.97%     
==========================================
  Files           7        7              
  Lines         281      312      +31     
==========================================
+ Hits          110      116       +6     
- Misses        171      196      +25
Impacted Files Coverage Δ
src/histogram.jl 27.35% <12.5%> (-4.05%) :arrow_down:
src/interface.jl 59.09% <0%> (+4.54%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60e143e...11832b9. Read the comment docs.

gdkrmr commented 5 years ago

Very cool, thanks! Could you please add some numerical tests for the computed statistics.

gdkrmr commented 5 years ago

Thanks for this, we will drop 0.7 support, so don't worry about the failing tests.