gdkrmr / WeightedOnlineStats.jl

Weighted version of OnlineStats.jl
MIT License
10 stars 4 forks source link

Great job! Thanks, small mistake at the beginning of hints fit!(WeightedMean, values, weights) not works;) #35

Closed programistawpf closed 4 years ago

programistawpf commented 4 years ago

Great job! I tried algebraically myself but it is beautiful! One little thing: the tutoril has a mistake at the beginning:

# fit using arrays:
o1 = fit!(WeightedMean, values, weights)

Must be:

o1 = WeightedMean()
fit!(o1, values, weights)

Paul

gdkrmr commented 4 years ago

Actually fit! should have a return value. But you are right, that the example does not work, it should be

o1 = fit!(WeightedMean(), values, weights)
gdkrmr commented 4 years ago

Thanks for reporting! Corrected