search

gdkrmr / WeightedOnlineStats.jl

Weighted version of OnlineStats.jl
MIT License
10 stars 4 forks source link

allow StatsBase 0.33 #37

Closed tpapp closed 4 years ago

tpapp commented 4 years ago

Does the package need to depend on StatsBase 0.32.1 explicitly, or would 0.32, 0.33 do? Is it https://github.com/JuliaStats/StatsBase.jl/issues/556?

Incidentally, please consider enabling https://github.com/bcbi/CompatHelper.jl/

gdkrmr commented 4 years ago

Thanks for the suggestion. One question regarding CompatHelper.jl: Am I supposed to use

[compat]
StatsBase = "0.33"

instead of 

[compat]
StatsBase = ">= 0.32.1"

with CompatHelper?

tpapp commented 4 years ago

My understanding is that once enabled, CompatHelper would make a PR adding comma-separated versions, eg

[compat]
StatsBase = "0.32.1, 0.33"

which is what you should use anyway (open-ended ranged will not be accepted in the registry).

gdkrmr commented 4 years ago

Ok, let's see if this works. Thanks!