gdkrmr / dimRed

A Framework for Dimensionality Reduction in R
https://www.guido-kraemer.com/software/dimred/
GNU General Public License v3.0
73 stars 15 forks source link

NNMF wrapper #18

Closed topepo closed 6 years ago

topepo commented 6 years ago

Updated from your develop branch

topepo commented 6 years ago

I've updated it to move from Imports to Suggests.

gdkrmr commented 6 years ago

ok, great, does it work on your computer? Travis currently complains:

1. Error: Bad args (@test_NNMF.R#188) 
invalid class "dimRedData" object: data must be numeric
1: expect_failure(embed(iris, "NNMF")) at testthat/test_NNMF.R:188
2: capture_expectation(expr)
3: tryCatch({
       code
       NULL
   }, expectation = function(e) e)
4: tryCatchList(expr, classes, parentenv, handlers)
5: tryCatchOne(expr, names, parentenv, handlers[[1L]])
6: doTryCatch(return(expr), name, parentenv, handler)
7: embed(iris, "NNMF")
8: embed(iris, "NNMF")
9: .local(.data, ...)
10: embed(as(.data, "dimRedData"), .method, .mute, .keep.org.data, ...)
11: as(.data, "dimRedData")
12: asMethod(object)
13: new("dimRedData", data = as.matrix(from))
14: initialize(value, ...)
15: initialize(value, ...)
16: .local(.Object, ...)
17: callNextMethod()
18: .nextMethod(.Object = .Object, data = data)
19: validObject(.Object)
20: stop(msg, ": ", errors, domain = NA)

Does it run on your computer?

topepo commented 6 years ago

It does now :-)

R CMD check was clean except that that I couldn't get that damn pcaL1 package to install. I guess it didn't run that particular test.

codecov-io commented 6 years ago

Codecov Report

Merging #18 into develop will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    74.62%   74.73%   +0.11%     
===========================================
  Files           15       15              
  Lines          863      863              
===========================================
+ Hits           644      645       +1     
+ Misses         219      218       -1
Impacted Files Coverage Δ
R/embed.R 91.17% <0%> (+2.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8383dac...dc5674a. Read the comment docs.

gdkrmr commented 6 years ago

cool, thank you, I will take a look at it as soon as I can!

gdkrmr commented 6 years ago

merged, added some goodies: Inverse function and moved W to the actual results. Thanks again!