gdkrmr / dimRed

A Framework for Dimensionality Reduction in R
https://www.guido-kraemer.com/software/dimred/
GNU General Public License v3.0
73 stars 15 forks source link

some Isomap procedural tweaks #5

Closed topepo closed 7 years ago

topepo commented 7 years ago

Fo the apply function, where you rbind the out of sample data with the training set, I used

lknng <- makeKNNgraph(rbind(indata, orgdata),
                      k = min(norg, pars$knn), eps = pars$eps)

but that may not be the best idea (I have no idea).

gdkrmr commented 7 years ago

I don't fancy adding more parameters for printing, most methods already have too many and I don't have access to the internals of the methods that I did not implemented myself. There is a generic way to suppress the output of every method by setting .mute = c("message", "output") in embed. Including "message", suppresses normal print output, "output" suppresses error messages, warnings and messages, the exact workings are not entirely clear to me, you can check out ?sink for more information. I should make this more clear in the documentation of embed.

emb <- embed(loadDataSet("Iris"), "Isomap", .mute = c("message"))
topepo commented 7 years ago

In the Rd files is is minus the dot:

emb2 <- embed(dat[samp], "Isomap", mute = NULL, knn = 10)

Should I delete the PR?

gdkrmr commented 7 years ago

keep the part that fixes the bug with the nearest neighbors and add the fix for the documentation. Thanks by the way for checking all my code!

topepo commented 7 years ago

No problem; thanks for the package

gdkrmr commented 7 years ago

i am closing it,