search

gdkrmr / lsp-julia

MIT License
70 stars 19 forks source link

Vendored packages aren't used #22

Closed non-Jedi closed 4 years ago

non-Jedi commented 4 years ago

Even though you include all the LanguageServer.jl packages as submodules, there's nothing causing them to be used. Just doing --project= will still cause the versions from the normal depot at .julia/packages to be used. I'm investigating how the vs-code extension vendors dependencies for https://github.com/non-Jedi/eglot-jl/issues/4 and will report back with the proper way of doing this.

non-Jedi commented 4 years ago

The appropriate code from the vs-code extension is here:

https://github.com/julia-vscode/julia-vscode/blob/97ce2d61f8c836c058913a839d1a251f30eb4f7d/src/extension.ts#L152

Basically you run the main julia instance with the JULIA_DEPOT_PATH environment variable set and then pass as an argument what you want the depot path to look like in the view of the symbol server.

Still unclear where the depot is filled...

See non-Jedi/eglot-jl#4 for further updates.

non-Jedi commented 4 years ago

After further consideration, what y'all are doing probably does work. Please ignore.

I didn't realize that Julia allowed vendoring packages within a project.