search

gdlg / panoramic-depth-estimation

Eliminating the Blind Spot: Adapting 3D Object Detection and Monocular Depth Estimation to 360° Panoramic Imagery
https://gdlg.github.io/panoramic
Other
64 stars 10 forks source link

Some problems about function. #7

Open yuniw18 opened 4 years ago

yuniw18 commented 4 years ago

I think 

    def generate_image_left(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, -disp, self.params.fov)
        else:
            return bilinear_sampler_1d_h(img, -disp, self.params.fov)
    def generate_image_right(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, disp)
        else:
            return bilinear_sampler_1d_h(img, disp)

should be 

    def generate_image_left(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, -disp, self.params.fov)
        else:
            return bilinear_sampler_1d_h(img, -disp)
    def generate_image_right(self, img, disp):
        if self.params.equirectangular_mode:
            return bilinear_sampler_equirectangular(img, disp, self.params.fov)
        else:
            return bilinear_sampler_1d_h(img, disp)

Thank you.

gdlg commented 4 years ago

Hi @yuniw18 I haven’t had time to have a close look but what you say sounds right. Sorry about that.