search

gdombiak / OctoPod

Free open source client for OctoPrint
Apache License 2.0
229 stars 42 forks source link

Siri suggestions should not include cancelling a print #361

Closed jessearmstrong closed 4 years ago

jessearmstrong commented 4 years ago

I managed to cancel a print job today about 13 hours in because an OctoPod notification popped up (I don't even know what it was for, probably 50% announcement) and when i went to click on it there was a siri suggestion on the screen to instantly cancel my print. Which I tapped on by accident and instantly canceled my print. No confirmation warning or anything. I think canceling a print should be a more restricted thing that always require confirmation. I don't siri should be able to do it. I would hate for siri to activate accidentally and misunderstand me to cancel a print either. I don't know that I could reproduce it, but it was not fun.

gdombiak commented 4 years ago

Ouch! That sucks! Sorry that happened @jessearmstrong. Since this action is done via Siri, I'm not sure I can add a confirmation prompt to confirm the action. I will look into that option and if not then see of not donating that action. Maybe via a setup configuration.

gdombiak commented 4 years ago

IMG_1804

gdombiak commented 4 years ago

I'm not sure if change in configuration applies to already existing shortcuts. Might need to delete shortcut and create it again. Or maybe delete the app and recreate shortcuts. In my test I delete the app and things worked after I installed it again. Did not test before deleting the app. :(