gdombiak / OctoPod

Free open source client for OctoPrint
Apache License 2.0
229 stars 42 forks source link

Disconnect cancels print #429

Open umtauscher opened 3 years ago

umtauscher commented 3 years ago

Hi Gaston, thank you very much for your app, I just installed it on iOS and tried it out - sadly during a print in progress. I am a bit confused, because this issue is so old and still the disconnect stops the print and with that destroys the work in progress. Just to clear things up "disconnect printer" would in my interpretation disconnect the app from the octoprint instance. Instead it disconnected the printer from Octoprint. Is that correct? I even enabled the read only mode but still it destroys the running print. I would love to hear from you about this. TIA Umtauscher

gdombiak commented 3 years ago

Hi @umtauscher ,

Thanks for the feedback. Disconnect will disconnect OctoPrint from the printer. If you are printing from OctoPrint then the print will be aborted. To prevent doing this by mistake, in OctoPod you can go to Settings -> Prompts and enable confirmation before disconnecting. I think I will add to the FAQ what disconnect does so there is no (or less) confusion.

Thanks, Gaston

gdombiak commented 3 years ago

Added a new entry in the FAQ. Let me know if that helps and if you had other ideas.

Gaston

umtauscher commented 3 years ago

Thanks Gaston for your quick answer. I know now, what this does and I personally find it to really be in the wrong spot. Disconnecting will always lead to a print failure and I think this should be in the administrative spot where the other functions like restarting octoprint is. I find this function should not be on such a prominent spot on the main screen. In fact, who needs this function anyway while remotely checking a print? It would be very nice, if you would reconsider. Even when you set the UI to read only this function is active. That makes the readonly setting obsolete in my opinion. Anyways, thanks for your hard work. Cheers Umtauscher

gdombiak commented 3 years ago

That's a good point! I'm not sure about reorganizing the UI at this point but I can easily make the button respect the read-only setting. If many other people feel the same way about where the button is placed then we can figure out how to reorganize the UI.

umtauscher commented 3 years ago

Super, thanks. Very nice of you! Cheers

gdombiak commented 3 years ago

@umtauscher I was about to implement this and noticed that it is already implemented. Disconnect button is disabled when app is locked.

umtauscher commented 3 years ago

Hi,

if you think you implemented it, then it simply doesn‘t work. I just tested: I activated „automatically lock during print“ Started a print Everything is disabled only „disconnect“ is still active.

But I cannot pause a print, that‘s also disabled. I cannot cancel the print - ok that may be as expected. I cannot disable the lock function during print.

I hope that helps to clarify the problem. Thanks

mindnever commented 3 years ago

Hi,

How about having the essential info included in confirmation request itself as a first step. I also like the idea of (re)moving this button completely from such important part of the screen. How often is this functionality even used?

Thanks

umtauscher commented 3 years ago

removing it from the main screen would be fine by me. I would never disconnect from a remote printer anyways. Thanks

Wilhelm

Am 22.05.2021 um 19:30 schrieb Vladimir Zidar @.***>:

 Hi,

How about having the essential info included in confirmation request itself as a first step. I also like the idea of (re)moving this button completely from such important part of the screen. How often is this functionality even used?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Xalior commented 3 years ago

Can confirm this just happened to me 3hrs into an 11hr job! 😅

Maybe an "alert" asking to confirm, with a warning saying that it's disconnecting from the printer, not the app from the OctoPrint?

-Dx

gdombiak commented 3 years ago

Hey @Xalior, under Settings -> Prompts you can enable/disable a prompt before connecting or before disconnecting. There is no connection to connect/disconnect between OctoPod and OctoPrint. These actions are between OctoPrint and the Printer.