gdombiak / OctoPod

Free open source client for OctoPrint
Apache License 2.0
229 stars 42 forks source link

App crashes #525

Closed pereiranr closed 2 years ago

pereiranr commented 2 years ago

App crashes when attempting to go to files panel. This issue started after updating to octoprint 1.7.0

gdombiak commented 2 years ago

Hi @pereiranr , thanks for reporting this. I just updated to 1.7.0 and was not able to crash the app. Could you share the following with me so I can fix the crash:

  1. version of octopod you’re using. You can see this under settings. I recently fixed a crash with files in the last release
  2. Attach to this thread the exact list of your files. If you cannot share gcode then I’ll need exact list of file names though any hidden character might be missed hence getting files is preferred

Thanks Gaston

pereiranr commented 2 years ago

Hey, Thanks for the quick reply. I’m very green on the software side so please bear with me. I did include screenshots of the software version and of the files I had on there. Please let me know if I can provide any further information that may help. Regards

Sent from my iPhone

On Oct 11, 2021, at 10:34 PM, Gaston Dombiak @.***> wrote:

 Hi @pereiranr , thanks for reporting this. I just updated to 1.7.0 and was not able to crash the app. Could you share the following with me so I can fix the crash:

version of octopod you’re using. You can see this under settings. I recently fixed a crash with files in the last release Attach to this thread the exact list of your files. If you cannot share gcode then I’ll need exact list of file names though any hidden character might be missed hence getting files is preferred Thanks Gaston

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

gdombiak commented 2 years ago

No need to apologize. Life is a learning journey and we never stop learning new things. Where were they uploaded? I do not see them in here. If you prefer you can send them to my gmail account. gdombiak at gmail

Gaston

ericsnis commented 2 years ago

I have also been experiencing crashes on OctoPod for iOS after updating Octoprint to 1.7. The crash occurs when attempting to view the files list. The app seems to show the camera feed just fine.

I tried the following Uninstalling then reinstalling OctoPod from the iPhone. Uninstall with purge data of the OctoPod plugin in Octoprint. Reinstalled again from the plugins browser in Octoprint. Delete the printer from the Settings > Printers menu. Then adding the printer again. Reset iCloud data from printers under the Settings > Devices menu.

The device is a iPhone 11 running iOS 15.0.2. OctoPod is version 3.13 build 1.

Is there a log on OctoPod that I can send?

gdombiak commented 2 years ago

Hi @ericsnis , does the crash happen every time you go to the Files window?

To share crash reports, in your iPhone go to Settings -> Privacy -> Analytics & Improvements. Check that Share With App Developers is enabled. I see no reported crashes when requesting Files or opening Files window. :(

Thanks, Gaston

Magnumforce40FR commented 2 years ago

Hi I have same issue as ericsnis after octoprint update to 1.7. Crash occures every time i try to access files. It seems app just hide but dont access files for one time and crash at second time. I also tried reinstalling Octopod version 3.13 build 1 from iPhone Xs running iOS 15.0.2. Improvements activated on iPhone

++

ericsnis commented 2 years ago

Hi @ericsnis , does the crash happen every time you go to the Files window?

To share crash reports, in your iPhone go to Settings -> Privacy -> Analytics & Improvements. Check that Share With App Developers is enabled. I see no reported crashes when requesting Files or opening Files window. :(

Thanks, Gaston

Ok, I have it enabled and I synced my phone when iTunes since I thought that I heard it won't upload logs without syncing.

Yes the crash occurs every time the files list is accessed. The crash only seems to happen when I click on the files button at the bottom of the app. Other functions like sending custom commands for lighting work fine.

There is an error thrown when I click Print from the Panel item if I am reprinting the last file that Octoprint had open. The app doesn't crash, it just shows a message reading Job Failed to request to print job again OctoPod print error msg

gdombiak commented 2 years ago

Ok, I now see some app crashes when going to Files and when using Slicer Thumbnails plugin. Could you guys confirm that you are using that plugin? If you do, as a quick test could you disable it (no need to remove it) and restart OctoPrint and let me know if still crashes?

Thanks, Gaston

gdombiak commented 2 years ago

Screen Shot 2021-10-14 at 12 07 33 AM

Have a fix for this error that I suspect is what is causing this issue. Will release a new beta with this fix. It would be great if you guys can help test the beta to confirm things are working fine again. Let me know if you would be interested in testing the fix.

Thanks, Gaston

Magnumforce40FR commented 2 years ago

Hi I confirm Slicer Thumbnails (1.0.0) in use. The bug disapear as the corrupted thumbnails gone when printed.

gdombiak commented 2 years ago

Hi @Magnumforce40FR, thanks for confirming that thumbnails is related to this issue. I'm curious what you mean by corrupted thumbnail. Could you share more info so I can reproduce it locally?

Thanks, Gaston

Magnumforce40FR commented 2 years ago

I can share you the files https://tilien.fr/ptCdz4 https://tilien.fr/ptaZmh Pictures are correct in octoprint

gdombiak commented 2 years ago

Guys, it would be great if you can help test the new beta to confirm the app crash is now gone. Send me an email to gdombiak at gmail if you would like to test the new beta and confirm this issue is resolved.

Thanks, Gaston

Magnumforce40FR commented 2 years ago

Hi Gaston I am ok for testing ++

Envoyé de mon smartphone

Le 14 oct. 2021 à 21:00, Gaston Dombiak @.***> a écrit :

 Guys, it would be great if you can help test the new beta to confirm the app crash is now gone. Send me an email to gdombiak at gmail if you would like to test the new beta and confirm this issue is resolved.

Thanks, Gaston

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

pereiranr commented 2 years ago

I will be happy to test out the beta. I have not had anymore crashes since you figured out the number in one of my files was causing the crash for me. But seems others are having issues. Regards Sent from my iPhone

On Oct 14, 2021, at 3:00 PM, Gaston Dombiak @.***> wrote:

 Guys, it would be great if you can help test the new beta to confirm the app crash is now gone. Send me an email to gdombiak at gmail if you would like to test the new beta and confirm this issue is resolved.

Thanks, Gaston

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.