gdombiak / OctoPod

Free open source client for OctoPrint
Apache License 2.0
225 stars 42 forks source link

TPLink plugs not appearing at all in app #538

Closed joshuacant closed 2 years ago

joshuacant commented 2 years ago

Hi, I have the following set up:

Octopi 0.18.0 Octoprint 1.7.0 OctoPod Plugin 0.3.11 TP Link Plugin 1.0.1 OctoPod iOS App 3.15

Everything works as you would expect it to. I can control the TPLink plug via the Octoprint WebUI, I can access OctoPrint via OctoPod and view/control my printer. However, the app does not display the TPLink plugs for me to control. They just aren't there. I've seen screenshots from others, including some posted to this github, and the panel where they should be is completely missing.

Is this a configuration error on my end, or was the feature for controlling TPLink plugs removed at some point? Most of the posts I see about it are 2-3 years old now, so that seems like a possibility.

Thanks for your time, and all your hard work on this app.

gdombiak commented 2 years ago

Hi @joshuacant,

I created this quick demo that shows how to access TPLink from OctoPod. Is the page that shows configured plugins appearing empty? If that's the case, could you share with me the names of your plugs so I can see if I can reproduce the issue?

FYI, I'm submitting a PR to the developer of TPLink plugin since OctoPod will not refresh UI when you turn on the plug from OctoPod.

Thanks, Gaston

joshuacant commented 2 years ago

Hi, thanks for the reply. I've attached a screenshot I just took of Octopod on my iPhone. capture

I only have 4 panels to swipe through. I don't have the other plugins shown in the video however, so I guess that's no great surprise. But I do have the TPLinkSmartplug one:

capture2

So I think if I understand your second question, it's not that the page showing plugs is empty, it's not there at all.

gdombiak commented 2 years ago

Hi Joshua,

I think I see what is going on. The plug seems to not have a name. This is how I set it up in my local environment.

Screen Shot 2021-10-24 at 5 13 31 PM

Screen Shot 2021-10-24 at 5 17 21 PM

Once a name has been entered, plugs will appear in OctoPod as shown in the demo. Let me know if this is not working for you.

Thanks, Gaston

gdombiak commented 2 years ago

BTW, remember to swipe to the right (or left) the bottom panel so you can access more functionality in OctoPod like temp charts, RPi temp chart, system commands and any other plugin that you have installed like TPLink.

Gaston

joshuacant commented 2 years ago

Yep, that fixed it. I left that blank because the TPLink plugin describes it thusly:

image

and I didn't think a name only visible in a tool tip was necessary. That said, now that I have entered it, I see that the TP Link plugin itself uses it as the plug's name. I know I'm barking up the wrong tree here, but I think that input should be changed from Label to Name and made a required field.

Thank you for your help. In the end it did end up being a mis-configuration on my part, so I apologize for taking up your time with it.

gdombiak commented 2 years ago

Gotcha. Sorry for the confusion. Agreed that it would be a good idea to have that field required specially if you have multiple plugs that you can control.

FYI, if you turn on a switch from OctoPod the UI will not refresh to show that it was successful (you have to swipe to another pane and come back to get it refreshed). It works well when you turn off plugs though. I sent an improvement request to the plugin developer to get this fixed.

Always happy to help. Let me know if you need help with anything else or want to see anything else implemented.

Regards, Gaston