search

gdombiak / OctoPod

Free open source client for OctoPrint
Apache License 2.0
225 stars 42 forks source link

Octorelay support implementation #540

Closed bastienstefani closed 2 years ago

bastienstefani commented 2 years ago

Hello @gdombiak I made some changes to support Octorelay plugin within the app. I matches the discussions we had in issue #476 Necessary changes have been made on plugin side.

gdombiak commented 2 years ago

Impressive work @bastienstefani. Took a quick look and looks very good over all. Once I merged it, I will test that it will adapt to any font size (I saw a fix row and header height so might need to change that) and I think that there is one line that may trigger an app crash so will move setting of octorelay array in main thread. Will test and merge PR tomorrow (prob not tonight).

I assume that this PR requires new APIs supported by octorelay plugin. Is this correct? If so, do you know when plugin will be updated to have new APIs?

Thanks for this great contribution.

bastienstefani commented 2 years ago

Hello @gdombiak, octorelay plug-in has already been updated (made the pull request last week and was merged) Feel free to modify anything in the PR, I tried to fit as much as possible to your architecture so it's easy to maintain. I'm new to swift so maybe I made a wrong choice with the fixed sizes, sorry about that

bastienstefani commented 2 years ago

Hello @gdombiak, back with some news, the octorelay plugin has a new release version (1.2.0) which contains the api entry point. So everything seems to be good now