Supporting OctoRelay API v2 with backward compatibility

gdombiak / OctoPod

Free open source client for OctoPrint

Apache License 2.0

230 stars 42 forks source link

Supporting OctoRelay API v2 with backward compatibility #662

Closed RobinTail closed 1 year ago

RobinTail commented 1 year ago

Closes #661

This PR is featuring the support of the OctoRelay plugin's API v2 without loosing backward compatibility.

Changes:

Including version: 2 into each API request,
When parsing the relay listing response, handle status entry (if present) with a fallback to ~~active~~ (deprecated),
When switching a relay, including subject entry into request, as well as ~~pin~~ (deprecated)

Tested manually using:

Xcode 15.0.1
IPhone SE simulation (2nd gen.) running IOS 16.4
OctoPrint 1.9.3
OctoRelay 3.14.0

I'm new to Swift, so I'm open to any suggestions, corrections and advices.

RobinTail commented 1 year ago

@gdombiak , please review

RobinTail commented 1 year ago

@gdombiak , please review

gdombiak commented 1 year ago

Hi Anna,

Thanks for PR. I will review and include it for the next release.

Regards, Gaston

On Thu, Nov 16, 2023 at 10:42 AM Anna Bocharova @.***> wrote:

@gdombiak https://github.com/gdombiak , please review

— Reply to this email directly, view it on GitHub https://github.com/gdombiak/OctoPod/pull/662#issuecomment-1815027645, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANVKI7JUIBDTQ4FPZIHMBDYEZNAJAVCNFSM6AAAAAA65PPW7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJVGAZDONRUGU . You are receiving this because you were mentioned.Message ID: @.***>

-- You can't control the wind, but you can adjust your sails -- Yiddish proverb

gdombiak commented 1 year ago

Anna, I will push a new release this week so your PR got just in time. It's now merged into master.

Thanks, Gaston