gdomenici / plugin.video.pcloud-video-streaming

Plugin for Kodi (Matrix and above) to provide video streaming from pcloud.com
GNU General Public License v3.0
14 stars 3 forks source link

v1.4.3 - Update Login Method and fix Login Problem with several Servers like EU #31

Closed lukkie112 closed 3 years ago

lukkie112 commented 3 years ago
gdomenici commented 3 years ago

Many thanks for the PR @lukkie112 . As soon as I have some contiguous time I'll review it properly and, if all OK, will merge. On first glance, everything looks OK though. Kind regards, Guido

lukkie112 commented 3 years ago

I will ask my friend,if he can make the changes you would like

gdomenici commented 3 years ago

I will ask my friend,if he can make the changes you would like

Hi @lukkie112

Thanks for that.

Another possibility (an alternative that may make your life easier) is the following:

  1. You branch the code in your repo from master to another branch name. For example (just an example) eapi-access-changes.
  2. you cancel this current PR.
  3. then you do a new PR with the existing code (no changes) from that new branch to a same-named branch in my repo.
  4. then I (not you) merge that PR to that new branch in my repo.
  5. then I do the necessary modifications to your code myself
  6. and when I'm done I merge to my master.

That would make your life easier. Or, of course, you can proceed as you propose above, i.e. your friend does the necessary changes. (But even in that case, i'd recommend using a new branch name). Up to you.

Kind regards,

Guido

lukkie112 commented 3 years ago

I was doing an new PullRequset with a new branche: Pcloud eu us login #37

So I close this one here