search

gdomenici / plugin.video.pcloud-video-streaming

Plugin for Kodi (Matrix and above) to provide video streaming from pcloud.com
GNU General Public License v3.0
14 stars 3 forks source link

Pcloud eu us login #37

Closed lukkie112 closed 3 years ago

lukkie112 commented 3 years ago

Hi. Sorry for long waiting to this pull requste. Few Month ago we spoke about this pull request in this threat: v1.4.3 - Update Login Method and fix Login Problem with several Servers like EU #31

I have forgotten, sorry me.

So, now i am doing a pull request with new branch. You can than edit it yourself like your wishes. I hope you will merge it than and make it availabel for Kodi18 and Kodi 19

I close the pull request #31 now

gdomenici commented 3 years ago

Hi @lukkie112 ,

Many thanks for the PR. While it works, im not 100% happy about putting credentials in cleartext in the config file (security best practices).

So i took the liberty of creating a new PR, https://github.com/gdomenici/plugin.video.pcloud-video-streaming/pull/39, where i implement it in a way that a) should fulfill your requirement and b) follows security best practices.

Please if you review that PR, and, if you like it, I can merge it into my master. I will leave this PR open for the time being, with the intention of closing it if the other one is OK.

Kind regards,

Guido

gdomenici commented 3 years ago

Closing PR - i addressed this in a separate PR, and the fix is now available in 1.5.1.