search

gdotdesign / elm-ui

UI library for making web applications with Elm
https://elm-ui.netlify.com
BSD 2-Clause "Simplified" License
923 stars 39 forks source link

KitchenSink demo in Webkit\Safari #5

Closed gothy closed 8 years ago

gothy commented 8 years ago

Please check out how Elm UI demo works in webkit. Feels very slow on both mobile and on desktop. Also dropdowns and few other widgets doesn't seem to work.

Thanks for your work! :) :+1:

gdotdesign commented 8 years ago

Thanks for the bug report!

I'll look into the bugs and as for the slowness it's not really optimized yet, also the it does a lot of unnecessary calculations (create records for read-only and disabled states on every change resulting in re-rendering everything) so it's not representative of a real like app.

gothy commented 8 years ago

Dropdowns are working now. Cool :)

However playing with the demo in Safari is not just slow, it crashes the Safari tab in just two minutes of "clicking all the things"

gdotdesign commented 8 years ago

I just deployed an optimized version of KitchenSink, the average render time per frame is now ~ 2ms down from ~ 15ms (for me in chrome), can you check it if there is improvement for you?

gothy commented 8 years ago

Not really :( You should try it yourself to feel the difference between chrome and safari. It's drastic

Also, something is wrong with css after update, since Calendar now looks like this and this is how it looks on localhost before pull

Made a video on all issues I've found http://take.ms/I0zu3

Tried to fix the issue with Dropdown and make a PR for it but failing so far :)

gdotdesign commented 8 years ago

Hey, thanks for all the inputs.

I managed to get my hands on a Safari finally (9. something) and I tracked the junk in scrolling to the ColorPanel specifically the gradients in uses.

You can see the fixes in this commit: 8e67efa3170789e597bb47067a91efe559980fb4.

I pushed a new version of it to gh-pages, If it's good for you too i'll close this issue.

Edit: The Calendar for me was fine in Safari and in Chrome, if you can tell me the version of the Safari you are using I can investigate further.

gothy commented 8 years ago

Lags are gone! :+1: :fireworks:

Safari 8.0.7, I'm still on Yosemite.