search

gdotdesign / elm-ui

UI library for making web applications with Elm
https://elm-ui.netlify.com
BSD 2-Clause "Simplified" License
920 stars 39 forks source link

Return dummy patchStyles function if document is not defined #77

Closed bakkdoor closed 7 years ago

bakkdoor commented 7 years ago

This fixes an error when using elm-ui with https://github.com/rtfeldman/elm-css. Running elm-css resulted in the following error without this fix:

Error: ReferenceError: document is not defined

This happened because elm-css is run using node when generating the css output and it doesn't have document defined.

gdotdesign commented 7 years ago

Thanks! :+1:

bakkdoor commented 7 years ago

Awesome, thanks for the fast merge 🎉

bakkdoor commented 7 years ago

Is there an easy way to reference the latest version using elm-install? If I run elm-install it installs 1.2.0 without this change. Or would it be possible to create a new patch release with 1.2.1?

bakkdoor commented 7 years ago

Nevermind, found the dependency-sources config mentioned in elm-install's docs. I'll just use that until a new release has been made. Thanks again for fast merge.

gdotdesign commented 7 years ago

Released as 1.2.1 :smile:

bakkdoor commented 7 years ago

👍