Closed pmusaraj closed 5 years ago
@pmusaraj Does this require changes in the fontawesome branch to work correctly, or can I merge it now?
Don't merge it yet, I think some of the CSS isn't backwards-compatible.
Sorry for the delay, this is good to merge now, it doesn't break current functionality.
Note also that any icon can be used in the plugin setting UI, and Discourse will automatically include that icon in the SVG subset.
Thanks @pmusaraj !
In the upcoming Discourse release, FontAwesome 4.7 font icons will be replaced by FA5 and SVGs. This PRs makes this plugin compatible with these changes in Discourse core. (I will write a guide on Meta shortly and update this PR's description with a link.)