search

gdpelican / retort

A reactions plugin for Discourse
MIT License
57 stars 39 forks source link

Upgraded retort list #40

Closed angusmcleod closed 5 years ago

angusmcleod commented 5 years ago

@gdpelican This converts the retort count style to the Discourse standard, i.e. the same as the like count, showing a list of users who have retorted with the specific retort below the post.

The change is toggled with a site setting "retort standard count", partly for the purposes of comparison in testing. This could be removed if you wanted to go this way entirely with retort counts.

screenshot at dec 04 12-03-01
gdpelican commented 5 years ago

Thanks for that; I've got this one the list for this weekend :)

gdpelican commented 5 years ago

Thanks for the feedback on this one @angusmcleod :) However, this isn't quite working for me at the moment; I've installed the branch on discourse-babble.com (https://discourse-babble.com/t/why-is-the-picture-distorted/130) to help troubleshoot.

captura de pantalla 2018-12-16 a la s 9 58 15 a m

the styling seems a bit odd (should the number be in a box like that? Should the avatar image be a bit spaced out from the text?), and the name of the reaction doesn't appear to be showing up (although I did have it showing up in some instances on my local machine) Would you mind having a play to see what might be going on?

angusmcleod commented 5 years ago

@gdpelican :+1: This should address those issues: https://github.com/gdpelican/retort/pull/40/commits/e5006c1cc9b2225bba36b9ff2ea5fce76c576272

gdpelican commented 5 years ago

Great, I'll have another hoon tonight :)

gdpelican commented 5 years ago

@angusmcleod I think we may need another trigger or two to refresh the reaction list, as there's some odd behaviour that you can get by adding/removing reactions while the list is open

https://www.useloom.com/share/6fb50196290c4c179bb9a25446fdc6d0

gdpelican commented 5 years ago

I thought I'd check back in on this one @angusmcleod ; are you interesting in pushing this one through?

angusmcleod commented 5 years ago

Hey, yup will be working on this one today 👍

angusmcleod commented 5 years ago

I think we may need another trigger or two to refresh the reaction list, as there's some odd behaviour that you can get by adding/removing reactions while the list is open

@gdpelican I've added an extra refresh when the retort being toggled is the same as the count currently open: https://github.com/gdpelican/retort/pull/40/commits/50ef518130f9aba1dce0ec48c8bc12d40a9bc8ee

gdpelican commented 5 years ago

Thanks for your work on this one @angusmcleod !