search

gdpelican / retort

A reactions plugin for Discourse
MIT License
57 stars 39 forks source link

Error after updating to latest version. #47

Closed dardub closed 4 years ago

dardub commented 5 years ago

I'm getting the following error after upgrading to 

Uncaught TypeError: _.contains is not a function
    at i.disabledFor (retort-e41b596fc8d6a1bf400b10ff3f24ecd72b4c75a88fd986dcb98b22615139d65f.js:sourcemap:1)
    at retort-e41b596fc8d6a1bf400b10ff3f24ecd72b4c75a88fd986dcb98b22615139d65f.js:sourcemap:1
    at application-cffbb65a89dd77321a977b2a67e2c545f3fe228ef17b85c18ac3278a4e42a85f.js:sourcemap:75
    at Array.map (<anonymous>)
    at u (application-cffbb65a89dd77321a977b2a67e2c545f3fe228ef17b85c18ac3278a4e42a85f.js:sourcemap:75)
    at t.html (application-cffbb65a89dd77321a977b2a67e2c545f3fe228ef17b85c18ac3278a4e42a85f.js:sourcemap:73)
    at t.value (application-cffbb65a89dd77321a977b2a67e2c545f3fe228ef17b85c18ac3278a4e42a85f.js:sourcemap:75)
    at t.value (application-cffbb65a89dd77321a977b2a67e2c545f3fe228ef17b85c18ac3278a4e42a85f.js:sourcemap:75)
    at i (vendor-fae393575cd14697b31e9fdbeb8c016d165a8a3af765ec8ca719a454585aedf4.js:sourcemap:5)
    at r (vendor-fae393575cd14697b31e9fdbeb8c016d165a8a3af765ec8ca719a454585aedf4.js:sourcemap:5)

Are we relying on lodash dependency from Discourse?

dardub commented 4 years ago

Hi. Is anyone else experiencing this? We had to uninstall the plugin and are not able to use it on the forum.

dardub commented 4 years ago

I can submit a PR on this if you can give me a little detail whether lodash should be added as a dependency or not?

gdpelican commented 4 years ago

This should be resolved in the latest version now :)