search

gdpelican / retort

A reactions plugin for Discourse
MIT License
57 stars 39 forks source link

After discourse update reaction modal showing white blank #52

Closed TheBaby5 closed 4 years ago

TheBaby5 commented 4 years ago

https://i.gyazo.com/c5b8f8601b070f7c2a905bd80c3f86c3.mp4

Please check the above video capture, after discourse update retort stopped working, when I try to click on emoji icon the popup modal is showing white blank as shown in the video & the below image.

image

hifihedgehog commented 4 years ago

Yes, Retort is no longer working with the latest version of Discourse. I just get the same blank popup now.

slambert commented 4 years ago

I'm seeing this also, on the current release.

slambert commented 4 years ago

I just updated another discourse install and got the same result. Did some quick troubleshooting to see if it was the recent CSS change in the last commit that made the difference, but it looks like the div for the emoji picker is empty for some reason. I had to move on, but hope that helps...

🤞

gdpelican commented 4 years ago

Thanks for the updates; I'm working on this today and will have a fix out by end of day. :D

On Sat, Apr 18, 2020 at 7:06 AM Steve Lambert notifications@github.com wrote:

I just updated another discourse install and got the same result. Did some quick troubleshooting to see if it was the recent CSS change in the last commit that made the difference, but it looks like the div for the emoji picker is empty for some reason.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gdpelican/retort/issues/52#issuecomment-615414310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFXHDKSOUEXREVCICKICUDRNCSDPANCNFSM4MIYWRPA .

gdpelican commented 4 years ago

This one should now be fixed 👍

theblazehen commented 4 years ago

Having issues with the "recently used" emojis after the upgrade, is it a me problem or anyone else affected?

Number of reactions of a specific type aren't being reflected either

hifihedgehog commented 4 years ago

Can confirm. Those "number of reactions" @theblazehen is referring are custom emojis. After the fix was applied to issue #52, custom emojis no longer display correctly. Bear in mind that reactions made prior to the fix still display. Please fix this.

Example of a Retort reaction being made after the fix (not working): https://forum.farfarawaynews.com/t/star-wars-episode-i-racer-coming-to-ps4-and-switch-in-may/837

Example of a Retort reaction that was already made before the fix (still working): https://forum.farfarawaynews.com/t/taylor-gray-gives-his-thoughts-on-the-rumored-rebels-sequel/822