search

gdpelican / retort

A reactions plugin for Discourse
MIT License
57 stars 39 forks source link

Custom emojis no longer working #54

Closed hifihedgehog closed 4 years ago

hifihedgehog commented 4 years ago

Related to #52. After the fix was applied to issue #52, custom emojis no longer display correctly. Bear in mind that reactions made prior to the fix still display. Please fix this.

Example of a Retort reaction being made after the fix (not working): https://forum.farfarawaynews.com/t/star-wars-episode-i-racer-coming-to-ps4-and-switch-in-may/837

Example of a Retort reaction that was already made before the fix (still working): https://forum.farfarawaynews.com/t/taylor-gray-gives-his-thoughts-on-the-rumored-rebels-sequel/822

gdpelican commented 4 years ago

Hmm, I'm not able to reproduce this; here's a video of me trying: https://www.loom.com/share/cb1e61a819044f9a9645ed056e04b1cc

Any additional information about how that faulty reaction came to be?

hifihedgehog commented 4 years ago

The only thing that stands out is the custom emoji all have ::[name]:: with double colons, which the built-in emojis don't have.

hifihedgehog commented 4 years ago

Ah, I found the caveat! Typing in the emoji name like you do, they work! But leaving it blank WITHOUT typing anything and then selecting any of the custom emojis doesn't work. In this case, it will apply the double colons.

gdpelican commented 4 years ago

Huh, very weird. I'll have a look today.

gdpelican commented 4 years ago

This appears to be a bug in discourse core, which actually looks like it's already been fixed by this commit: https://github.com/discourse/discourse/commit/cfe510cbcf7c3fa9a9407c17d8eba735a23ecc96

Try updating discourse again and see how you go?