search

gdpelican / retort

A reactions plugin for Discourse
MIT License
57 stars 39 forks source link

Does not work with 2.5.0.beta4 #64

Closed aaronpk closed 3 years ago

aaronpk commented 4 years ago

I upgraded from 2.5.0.beta2 to 2.5.0.beta4 today and this plugin caused the entire forum to break due to a JS error in this plugin.

The error in the console is unfortunately not very helpful:

_ember_jquery-3a388c5a0562670ed1eea762f12e041d92b4a418316d3f9f83e793d3ba6be5d7.js:4060 jQuery.Deferred exception: Cannot read property 'find' of undefined TypeError: Cannot read property 'find' of undefined
    at t.postFor (https://forum.ohmydollar.com/assets/plugins/retort-2b5f24e04afd560bb80ec54c5a13ff2bb05edb69aa06e7aa11af1be8275a56c0.js:1:1494)

I have to disable this plugin for now until this is fixed.

gdpelican commented 4 years ago

👋 Looks like you may have a funky topic somewhere which doesn't have a postStream set properly.

Try updating to the latest version of retort, which should now account for this possibility :)

aaronpk commented 4 years ago

Is there a way to upgrade this plugin specifically? I just ran the regular ./launcher rebuild app which upgraded Discourse itself, and I assume would also grab the latest from this plugin.

gdpelican commented 4 years ago

That'll do it to upgrade everything, or you can try visiting https://<your instance>/admin/upgrade to upgrade specific plugins / discourse itself.

On Mon, May 18, 2020 at 3:41 PM Aaron Parecki notifications@github.com wrote:

Is there a way to upgrade this plugin specifically? I just ran the regular ./launcher rebuild app which upgraded Discourse itself, and I assume would also grab the latest from this plugin.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gdpelican/retort/issues/64#issuecomment-629928842, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFXHDIKSXAS4LGKWR5GZ3TRSCVADANCNFSM4NDVSHNA .

aaronpk commented 4 years ago

hm okay, that's what I ran and when it came back online I was getting this error