Emoji-button - No on-click reaction (Widget not showing)

gdpelican / retort

A reactions plugin for Discourse

MIT License

57 stars 39 forks source link

Emoji-button - No on-click reaction (Widget not showing) #70

Closed exetico closed 3 years ago

exetico commented 3 years ago

Hi,

Our reaction button got broken after the latest update. By clicking it, nothing happens. No JS-errors is thrown in the console, by clicking it. I can't really tell what's going on.

We're on the latest build, with all plugins updated, too.

Johannestegner commented 3 years ago

Having the same issue. Seeing nothing have changed in this repository since a while back, I would guess something changed in Discourse. If I find any way around it I'll post here :)

edapm commented 3 years ago

Yep, I think the latest update may have broken it.

Johannestegner commented 3 years ago

Yep, I think the latest update may have broken it.

There is a patch which allows it to show, but there are quite a few changes to the internal emoji selector code, so it's not working as good as before. A lot better than nothing at all, but could use some well deserved CSS magic from someone who have a good eye to that stuff! :)

angusmcleod commented 3 years ago

This is now fixed: https://github.com/gdpelican/retort/commit/272fe4c643864a9a419248abc2fd2e81258d3478