Possible Blueprint leak in FurnaceGUI.gd

gdquest-demos / godot-2d-builder

A simulation game demo made in Godot and inspired by Factorio.

MIT License

479 stars 38 forks source link

Possible Blueprint leak in FurnaceGUI.gd #5

Closed sadovsf closed 3 years ago

sadovsf commented 3 years ago

In function grab_output is checking held_item_id == item_id but there is missing case what to do if not.

In simplest case item.queue_free() should be called for missing else code branch to release BlueprintEntity. Ideally some handling so player does not loose this prepared item.

Razoric480 commented 3 years ago

I'll double check for missing edge cases with that function. Thanks.

sadovsf commented 3 years ago

No problem :-) Maybe check out this place for other machines as they may contain this issue as well (i did not check them explicitly as code was not complete yet)