gdquest-demos / godot-2d-space-game

A 2D space exploration and mining game made with Godot and our AI framework
MIT License
837 stars 109 forks source link

[WIP] Implement ship rotation when docked #52

Closed Martialis39 closed 4 years ago

Martialis39 commented 4 years ago

To improve upon the game's polish, the player ship now rotates along with the dockable if the dockable rotates. At the time of implementation, the only rotating dockable is Station.

Please check if the PR fulfills these requirements:

Related issue (if applicable): #

What kind of change does this PR introduce?

Docked player ship now rotates with dockable.

Does this PR introduce a breaking change?

New feature or change

What is the current behavior?

Docked player ship's position is fixed.

What is the new behavior?

Docked player ship now rotates with dockable.

Other information

Martialis39 commented 4 years ago

I wanted to re-surface and get some feedback. I was able to implement the rotation, yet I am still facing one bug where the ship does not sit nicely on the radius of the Asteroids. I will look into this further over the weekend and any input is appreciated :)

Also, am I crazy or does the remote_path for this https://github.com/GDQuest/godot-2d-space-game/blob/master/project/src/World/DockingPoint/DockingPoint.gd#L23 never get set?

Martialis39 commented 4 years ago

Adding a pic of the bug Capture

NathanLovato commented 4 years ago

@Razoric480 could you do this review?

Martialis39 commented 4 years ago

@Razoric480 Thank you for your time and feedback, I will address these shortly!

Martialis39 commented 4 years ago

@Razoric480 Thank you again for your invaluable feedback! I was extremely busy in the meanwhile and only now managed to incorporate the changes. I will leave a longer comment later in the day detailing what I did.

Razoric480 commented 4 years ago

Thanks!